Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error if we try to have interfaces with auto properties on constructor-less types #16352

Merged
merged 19 commits into from
Dec 8, 2023
Merged

Raise an error if we try to have interfaces with auto properties on constructor-less types #16352

merged 19 commits into from
Dec 8, 2023

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Nov 28, 2023 •
edited
Loading

Description

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp edgarfgp marked this pull request as ready for review November 28, 2023 17:05
@edgarfgp edgarfgp requested a review from a team as a code owner November 28, 2023 17:05
@edgarfgp edgarfgp changed the title Raise a new error if we try to have interfaces with auto properties on constructor-less types Raise an error if we try to have interfaces with auto properties on constructor-less types Nov 28, 2023
@edgarfgp
Copy link
Contributor Author

This is ready

edgarfgp and others added 3 commits November 30, 2023 11:09
@edgarfgp @T-Gro
Update src/Compiler/Checking/CheckDeclarations.fs
b81a7d4 
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
@edgarfgp @T-Gro
Update src/Compiler/Checking/CheckDeclarations.fs
b288781 
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
@edgarfgp @T-Gro
Update tests/FSharp.Compiler.ComponentTests/ErrorMessages/ClassesTest…
8cc8e12 
…s.fs

Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
@psfinaki
Copy link
Member

psfinaki commented Dec 1, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member

psfinaki commented Dec 1, 2023

Hey @edgarfgp good stuff here. In the PR description, you mention benchmarks, do you still plan to add them?

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Dec 1, 2023

Hey @edgarfgp good stuff here. In the PR description, you mention benchmarks, do you still plan to add them?

Not applicable in this case. The check was there as part of the new PR template :). I guess I should remove it from the description

@psfinaki
Copy link
Member

psfinaki commented Dec 1, 2023

Ah okay, nevermind then :)

@T-Gro T-Gro merged commit fbfeb6d into dotnet:main Dec 8, 2023
26 checks passed
@allisonchou allisonchou mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok approved these changes

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edgarfgp @psfinaki @vzarytovskii @auduchinok @T-Gro